Add back stripped tags like Geometry lengths, dimensions and precision#130
Open
curtisko-amzn wants to merge 1 commit intomapbox:masterfrom
Open
Add back stripped tags like Geometry lengths, dimensions and precision#130curtisko-amzn wants to merge 1 commit intomapbox:masterfrom
curtisko-amzn wants to merge 1 commit intomapbox:masterfrom
Conversation
…n that is used by Golang Geobuf library
curtisko-amzn
changed the title
curtisko-amzn
changed the title
curtisko-amzn
changed the title
Author
|
@mourner would it be possible to get your thoughts on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use go-geobuf and compared to that implementation, the mapbox implementation seems to ignore writing certain data when the number of rings are low. I add this back to the implementation to make it consistent to the golang implementation